-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(structure-comapre): implement database object structure comparison #1364
feat(structure-comapre): implement database object structure comparison #1364
Conversation
...rvice/src/main/java/com/oceanbase/odc/service/structurecompare/OdcDBStructureComparator.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/oceanbase/odc/service/structurecompare/OdcDBStructureComparator.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/oceanbase/odc/service/structurecompare/OdcDBStructureComparator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DBObjectStructureComparator
's implementations have some duplicated code, can we reduce it? Maybe we lack some abstraction.
server/odc-service/src/main/java/com/oceanbase/odc/service/plugin/SchemaPluginUtil.java
Outdated
Show resolved
Hide resolved
...-service/src/main/java/com/oceanbase/odc/service/structurecompare/DBStructureComparator.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/oceanbase/odc/service/structurecompare/DefaultDBStructureComparator.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/oceanbase/odc/service/structurecompare/DefaultDBStructureComparator.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/oceanbase/odc/service/structurecompare/DefaultDBStructureComparator.java
Outdated
Show resolved
Hide resolved
.../com/oceanbase/odc/service/structurecompare/comparedbobject/DBObjectStructureComparator.java
Show resolved
Hide resolved
.../com/oceanbase/odc/service/structurecompare/comparedbobject/DBObjectStructureComparator.java
Outdated
Show resolved
Hide resolved
...ceanbase/odc/service/structurecompare/comparedbobject/TablePartitionStructureComparator.java
Outdated
Show resolved
Hide resolved
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…on (#1364) * implement OdcDBStructureComparator * delete SchemaBrowserExtensionPoint * response to review * add AbstractDBObjectStructureComparator * response to review
…on (#1364) * implement OdcDBStructureComparator * delete SchemaBrowserExtensionPoint * response to review * add AbstractDBObjectStructureComparator * response to review
What type of PR is this?
type-feature
modul-structure-compare
What this PR does / why we need it:
Implementation class of structure comparison task
DBStructureComparator
interface to compare database objects between two schema according to config.DBObjectStructureComparator<T extends DBObject>
interface to compare different database object types between two schema.DBObjectComparisonResult
,refer toDBObjectComparisonResult#getSubDBObjectComparisonResult()
.For table object,
DBObjectComparisonResult#getChangeScript()
only only record the change script of table options.MySQLTableEditor#generateUpdateTableOptionDDL
. Oracle do not support alter table charset and collate.Which issue(s) this PR fixes:
Fixes #816
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: